Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always sleep between iterations of generator handlers #2811

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Sep 3, 2024

Changes

  • Previously, generator handlers would only sleep if the iteration's return value was truthy
  • Now, asyncio.sleep() is always invoked for each generator iteration

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 marked this pull request as ready for review September 3, 2024 18:21
@rmartin16
Copy link
Member Author

rmartin16 commented Sep 3, 2024

CI testbed failure, fyi:

FAILED tests/widgets/test_webview.py::test_load_url - RuntimeError: Error Domain=WKErrorDomain Code=4 "A JavaScript exception occurred" UserInfo={WKJavaScriptExceptionLineNumber=1, WKJavaScriptExceptionMessage=TypeError: null is not an object (evaluating 'document.body.innerHTML'), WKJavaScriptExceptionColumnNumber=14, WKJavaScriptExceptionSourceURL=https://github.com/beeware, NSLocalizedDescription=A JavaScript exception occurred}

https://github.com/beeware/toga/actions/runs/10688375651/job/29628280415#step:6:768

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This is one of those "I know this has been here forever, but it's never annoyed me enough to fix it" bugs. Thanks :-)

@freakboy3742 freakboy3742 merged commit fb5add4 into beeware:main Sep 4, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants