Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS12 for black screen #2265

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Fix iOS12 for black screen #2265

merged 3 commits into from
Dec 8, 2023

Conversation

idbeny
Copy link
Contributor

@idbeny idbeny commented Dec 8, 2023

Modify toga_iOS/libs/uikit.py at line 273.

To fixed iOS12 black screen when launch.

#2262

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks like exactly what is needed; however the PR is failing CI because it is missing a changenote

In this case, we need a file named changes/2265.bugfix.rst that says something like "Font handling on older versions of iOS has been corrected."

@idbeny
Copy link
Contributor Author

idbeny commented Dec 8, 2023

The change looks like exactly what is needed; however the PR is failing CI because it is missing a changenote

In this case, we need a file named changes/2265.bugfix.rst that says something like "Font handling on older versions of iOS has been corrected."

Sorry, I was so careless.

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a minor tweak to correct a linting issue (we require all files to have a trailing newline) - but otherwise, this is great! Thanks for the report and fix!

@freakboy3742 freakboy3742 merged commit a5b0204 into beeware:main Dec 8, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants