-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cocoa Close Window shortcut is incorrect #2214
Comments
For what it's worth, there are non-persistent apps that use Cmd-w for close as well, such as Calculator, Find My, Dictionary, Clock, and Weather. I think the distinction is less persistent vs. non-persistent and more single-window vs. multi-window (or multi-tab). |
Yes, the impression I get is that the default on macOS is for Cmd-W to close the current window, unless the app offers a tab interface, in which case it closes the current tab. Single-window apps offer both Cmd-W and Cmd-Q, but they're the same except possibly for whether they leave the app running in the background. I don't remember seeing any app in which Cmd-W does nothing. So I'm so used to using it, that when it does nothing on Toga, it feels like a big surprise. |
I hadn't made the connection that Safari's behavior is related to the tabs in the interface. On that basis, I agree that "Close (CMD-W)" is the better standard to follow here. Interestingly, the code implementing this already explicitly mentions the discrepancy between Safari and other apps... |
Describe the bug
It should be Cmd-W, but the capital W is being translated into Cmd-Shift-W. Close All Windows is also affected.
We should add some shortcut tests to the testbed to cover this kind of thing.
Environment
The text was updated successfully, but these errors were encountered: