-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mbsync
/ missing
plugins: consider all metadata backends
#5636
base: master
Are you sure you want to change the base?
Conversation
mbsync\
/ \missing\
plugins: consider all metadata backendsmbsync
/ missing
plugins: consider all metadata backends
85a442f
to
46e822e
Compare
While I won't have time to review this in depth anytime soon, here's one thing that's unclear to me at a superficial glance:
Looking just at the changed code, it appears that Maybe this makes sense (possibly, a given |
46e822e
to
d960f36
Compare
That's exactly my thinking - I have worked with all available metadata sources, and I'm yet to discover a case where a single ID yields more than one album / singleton. I will add a comment under these methods. |
d960f36
to
5407d82
Compare
5407d82
to
e2f7af5
Compare
…s for artist And give this functionality a small refactor.
e2f7af5
to
371a369
Compare
This PR adds support for alternate metadata backends in the
mbsync
andmissing
plugins, allowing them to work with any metadata backend the items are tagged with instead of being limited to just MusicBrainz.Key changes:
albums_for_id
anditems_for_id
methods.album_for_id
andtrack_for_id
implementations to return a single album/track as their names suggest.missing
plugin docs to make it clear that missing albums for artists can only be obtained for themusicbrainz
metadata backendThe changes maintain backwards compatibility while enabling users to leverage metadata from sources like Deezer, Discogs or Bandcamp when syncing their libraries.
Note: this change came about because I'm working on making
musicbrainz
a separate plugin: this will be submitted in the next PR.