Skip to content

Conversation

@dhruvarayasam
Copy link
Contributor

  • Added a more descriptive error message for when the file at the specified modelPath in GGUF.java does not exist in the loadModel method.
  • Also added error handling if there was an issue loading in the particular model specified at modelPath.
  • Both give more descriptive error messages that help the user understand better what went wrong in loading the model.
  • Specified in Add Basic Error Handling for Missing Model Files #15

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2025

CLA assistant check
All committers have signed the CLA.

@mikepapadim mikepapadim self-assigned this Jun 27, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances error handling for model loading by providing more descriptive error messages when a model file is not found or fails to load.

  • Added a file existence check in the GGUF.loadModel method with a FileNotFoundException.
  • Updated comments in ModelLoader.java clarifying thrown exceptions.
  • Updated the TornadoVM subproject commit.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/main/java/com/example/loader/weights/ModelLoader.java Added clarifying comments regarding error types thrown during model loading.
src/main/java/com/example/core/model/GGUF.java Introduced an explicit file existence check and improved error messages.
external/tornadovm Updated the subproject commit.

@mikepapadim mikepapadim removed their assignment Jun 27, 2025
Copy link
Member

@mikepapadim mikepapadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution

@mikepapadim mikepapadim merged commit 78ae1ae into beehive-lab:main Jun 28, 2025
1 check passed
@dhruvarayasam dhruvarayasam deleted the file-not-found-fix branch June 29, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants