-
Notifications
You must be signed in to change notification settings - Fork 24
File not found error handling in loadModel method in GGUF.java #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File not found error handling in loadModel method in GGUF.java #34
Conversation
dhruvarayasam
commented
Jun 27, 2025
- Added a more descriptive error message for when the file at the specified modelPath in GGUF.java does not exist in the loadModel method.
- Also added error handling if there was an issue loading in the particular model specified at modelPath.
- Both give more descriptive error messages that help the user understand better what went wrong in loading the model.
- Specified in Add Basic Error Handling for Missing Model Files #15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request enhances error handling for model loading by providing more descriptive error messages when a model file is not found or fails to load.
- Added a file existence check in the GGUF.loadModel method with a FileNotFoundException.
- Updated comments in ModelLoader.java clarifying thrown exceptions.
- Updated the TornadoVM subproject commit.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/com/example/loader/weights/ModelLoader.java | Added clarifying comments regarding error types thrown during model loading. |
| src/main/java/com/example/core/model/GGUF.java | Introduced an explicit file existence check and improved error messages. |
| external/tornadovm | Updated the subproject commit. |
mikepapadim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for your contribution