Bug fix on CLEAR, that resulted in NPE. Added feature to allow FLAG_NO_CLEAR with backwards compatiblity.

Author: manijshrestha

Android/StatusBarNotification/README.md

@@ -26,6 +26,11 @@ The plugins.xml is no longer supported. The plugins are all located in the confi
 5. You will need to add an import line like this to the .java files (see commented out lines inside the files):
 
 	import com.my.app.R; 
+6. If you need the notification to stick, you can pass a paramter to notify function. 
+	E.g.:
+	   window.plugins.statusBarNotification.notify("Put your title here", "Put your sticky message here", Flag.FLAG_NO_CLEAR);
+           //you can then use clear function to remove it.
+	   window.plugins.statusBarNotification.clear();
 
 ## Using the plugin ##
 
@@ -59,4 +64,4 @@ NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
 HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
 WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
-OTHER DEALINGS IN THE SOFTWARE.
+OTHER DEALINGS IN THE SOFTWARE.

Android/StatusBarNotification/StatusBarNotification.java

@@ -37,8 +37,6 @@
 import android.app.NotificationManager;
 import android.content.Context;
 import android.content.Intent;
-
-import android.os.Handler;
 import android.util.Log;
 
 public class StatusBarNotification extends Plugin {
@@ -63,8 +61,10 @@ public PluginResult execute(String action, JSONArray data, String callbackId) {
                 String tag = data.getString(0);
                 String title = data.getString(1);
                 String body = data.getString(2);
+                String flag = data.getString(3);
                 Log.d("NotificationPlugin", "Notification: " + tag + ", " + title + ", " + body);
-                showNotification(tag, title, body);
+                int notificationFlag = getFlagValue(flag);
+                showNotification(tag, title, body, notificationFlag);
                 result = new PluginResult(Status.OK);
             } catch (JSONException jsonEx) {
                 Log.d("NotificationPlugin", "Got JSON Exception "
@@ -76,6 +76,7 @@ public PluginResult execute(String action, JSONArray data, String callbackId) {
                 String tag = data.getString(0);
                 Log.d("NotificationPlugin", "Notification cancel: " + tag);
                 clearNotification(tag);
+                result = new PluginResult(Status.OK);
             } catch (JSONException jsonEx) {
                 Log.d("NotificationPlugin", "Got JSON Exception " + jsonEx.getMessage());
                 result = new PluginResult(Status.JSON_EXCEPTION);
@@ -88,18 +89,37 @@ public PluginResult execute(String action, JSONArray data, String callbackId) {
     }
 
     /**
+     * Helper method that returns a flag value to be used for notification
+     * by default it will return 16 representing FLAG_NO_CLEAR
+     * 
+     * @param flag
+     * @return int value of the flag
+     */
+    private int getFlagValue(String flag) {
+		int flagVal = Notification.FLAG_AUTO_CANCEL;
+		
+		// We trust the flag value as it comes from our JS constant.
+		// This is also backwards compatible as it will be emtpy.
+		if (!flag.isEmpty()){
+			flagVal = Integer.parseInt(flag);
+		}
+		
+		return flagVal;
+	}
+
+	/**
      * 	Displays status bar notification
      *
      * 	@param tag Notification tag.
      *  @param contentTitle	Notification title
      *  @param contentText	Notification text
      * */
-    public void showNotification( CharSequence tag, CharSequence contentTitle, CharSequence contentText ) {
+    public void showNotification( CharSequence tag, CharSequence contentTitle, CharSequence contentText, int flag) {
         String ns = Context.NOTIFICATION_SERVICE;
         context = cordova.getActivity().getApplicationContext();
         mNotificationManager = (NotificationManager) context.getSystemService(ns);
 
-        Notification noti = StatusNotificationIntent.buildNotification(context, tag, contentTitle, contentText);
+        Notification noti = StatusNotificationIntent.buildNotification(context, tag, contentTitle, contentText, flag);
         mNotificationManager.notify(tag.hashCode(), noti);
     }
 

Android/StatusBarNotification/StatusNotificationIntent.java

@@ -1,19 +1,21 @@
 // This class is used on all Androids below Honeycomb
 package com.phonegap.plugins.statusBarNotification;
-// import com.yourapp.R;
+
 
 import android.app.Notification;
 import android.app.PendingIntent;
 import android.content.Context;
 import android.content.Intent;
 import android.content.pm.PackageManager;
 
+//import com.my.app.R;
+
 public class StatusNotificationIntent {
-    public static Notification buildNotification( Context context, CharSequence tag, CharSequence contentTitle, CharSequence contentText ) {
+    public static Notification buildNotification( Context context, CharSequence tag, CharSequence contentTitle, CharSequence contentText, int flag ) {
         int icon = R.drawable.notification;
         long when = System.currentTimeMillis();
         Notification noti = new Notification(icon, contentTitle, when);
-        noti.flags |= Notification.FLAG_AUTO_CANCEL;
+        noti.flags |= flag;
 
         PackageManager pm = context.getPackageManager();
         Intent notificationIntent = pm.getLaunchIntentForPackage(context.getPackageName());

Android/StatusBarNotification/statusbarnotification.js

@@ -27,6 +27,15 @@
 
 var cordovaRef = window.PhoneGap || window.Cordova || window.cordova; // old to new fallbacks
 
+/** 
+ * Flags to denote the Android Notification constants
+ * Values are representation from Android Notification Flag bit vals 
+ */
+
+function Flag() {}
+Flag.FLAG_AUTO_CANCEL="16";
+Flag.FLAG_NO_CLEAR="32";
+
 /** @deprecated Use the W3C standard window.Notification API instead. */
 var NotificationMessenger = function() { }
 
@@ -35,10 +44,11 @@ var NotificationMessenger = function() { }
  * @param body Body of the notification
  * @deprecated Use the W3C standard window.Notification API instead.
  */
-NotificationMessenger.prototype.notify = function(title, body) {
+NotificationMessenger.prototype.notify = function(title, body, flag) {
     if (window.Notification) {
         this.activeNotification = new window.Notification(title, {
-            body: body
+            body: body,
+            flag: flag
         });
     }
 }
@@ -83,6 +93,8 @@ if (typeof window.Notification == 'undefined') {
         this.onclose = options.onclose;
 
         var content = options.body || '';
+        
+        var flag = options.flag || '';
 
         cordova.exec(function() {
             if (this.onshow) {
@@ -92,7 +104,7 @@ if (typeof window.Notification == 'undefined') {
             if (this.onerror) {
                 this.onerror(error);
             }
-        }, 'StatusBarNotification', 'notify', [this.tag, title, content]);
+        }, 'StatusBarNotification', 'notify', [this.tag, title, content, flag]);
     };
 
     // Permission is always granted on Android.