-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to the just
build system and add release tooling
#429
Conversation
just
build system and release toolingjust
build system and add release tooling
@carreter per your request in the Discord I took a look at this and it looks great! Looks like your tests ran correctly too which is the big win! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carreter this is a great refactor. I'm excited for nightly builds and saving custom CI commands using just
was a good idea. Is there anything I'm missing or you'd like me to look at more in-depth before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to click on approve!
Changes in this PR
justfile
with documentation on how to use itWhy are you making these changes?
Having a unified build system will make it easier for devs to replicate what happens in our CI/CD systems locally. Also automation is good (generally)!
Are any changes breaking? (IMPORTANT)
No, these are purely devops changes
Pre-merge checklist
All of these must be satisfied before this PR is considered
ready for merging. Mergeable PRs will be prioritized for review.
primers/primers_test.go
for what this might look like.CHANGELOG.md
in the[Unreleased]
section.