Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the just build system and add release tooling #429

Merged
merged 19 commits into from
Dec 19, 2023

Conversation

carreter
Copy link
Collaborator

Changes in this PR

  • Create justfile with documentation on how to use it
  • Add GitHub action to automatically make a release on tag push

Why are you making these changes?

Having a unified build system will make it easier for devs to replicate what happens in our CI/CD systems locally. Also automation is good (generally)!

Are any changes breaking? (IMPORTANT)

No, these are purely devops changes

Pre-merge checklist

All of these must be satisfied before this PR is considered
ready for merging. Mergeable PRs will be prioritized for review.

  • New packages/exported functions have docstrings.
  • New/changed functionality is thoroughly tested.
  • New/changed functionality has a function giving an example of its usage in the associated test file. See primers/primers_test.go for what this might look like.
  • Changes are documented in CHANGELOG.md in the [Unreleased] section.
  • All code is properly formatted and linted.
  • The PR template is filled out.

@carreter carreter changed the title Migrate to the just build system and release tooling Migrate to the just build system and add release tooling Dec 19, 2023
@ethanholz
Copy link

@carreter per your request in the Discord I took a look at this and it looks great! Looks like your tests ran correctly too which is the big win!

Copy link
Collaborator

@TimothyStiles TimothyStiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carreter this is a great refactor. I'm excited for nightly builds and saving custom CI commands using just was a good idea. Is there anything I'm missing or you'd like me to look at more in-depth before merging?

.github/workflows/help_wanted_notify.yml Show resolved Hide resolved
.github/workflows/coverage.yml Show resolved Hide resolved
.github/workflows/lint.yml Show resolved Hide resolved
Copy link
Collaborator

@TimothyStiles TimothyStiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to click on approve!

@carreter carreter merged commit e52eeea into bebop:main Dec 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants