Skip to content

Commit ec0fb33

Browse files
committed
Renamed methods in Roman Numerial Converter
renamed "sym" to "rom_char" to clear confusion renamed "romanNum" to "roman_num" to match snake case
1 parent b0ab435 commit ec0fb33

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

bin/roman_numerals.rb

+12-12
Original file line numberDiff line numberDiff line change
@@ -5,32 +5,32 @@
55

66
length = sepNum.length
77

8-
def sym
8+
def rom_char
99
#0 1 2 3 4 5 6
1010
#1 5 10 50 100 500 1000
1111
["I", "V", "X", "L", "C", "D", "M"]
1212
end
1313

1414

15-
def romanNum(num, rom)
15+
def roman_num(num, rom)
1616
if num =="1"
17-
print "#{sym[rom]}"
17+
print "#{rom_char[rom]}"
1818
elsif num == "2"
19-
2.times{print "#{sym[rom]}"}
19+
2.times{print "#{rom_char[rom]}"}
2020
elsif num == "3"
21-
3.times{print "#{sym[rom]}"}
21+
3.times{print "#{rom_char[rom]}"}
2222
elsif num == "4"
23-
print "#{sym[rom]}#{sym[rom+1]}"
23+
print "#{rom_char[rom]}#{rom_char[rom+1]}"
2424
elsif num == "5"
25-
print "#{sym[rom+1]}"
25+
print "#{rom_char[rom+1]}"
2626
elsif num == "6"
27-
print "#{sym[rom+1]}#{sym[rom]}"
27+
print "#{rom_char[rom+1]}#{rom_char[rom]}"
2828
elsif num == "7"
29-
print "#{sym[rom+1]}#{sym[rom]}#{sym[rom]}"
29+
print "#{rom_char[rom+1]}#{rom_char[rom]}#{rom_char[rom]}"
3030
elsif num == "8"
31-
print "#{sym[rom+1]}#{sym[rom]}#{sym[rom]}#{sym[rom]}"
31+
print "#{rom_char[rom+1]}#{rom_char[rom]}#{rom_char[rom]}#{rom_char[rom]}"
3232
elsif num == "9"
33-
print "#{sym[rom]}#{sym[rom+2]}"
33+
print "#{rom_char[rom]}#{rom_char[rom+2]}"
3434
end
3535
end
3636

@@ -45,7 +45,7 @@ def romanNum(num, rom)
4545
end
4646

4747
for x in 0...length
48-
romanNum(sepNum[x],y)
48+
roman_num(sepNum[x],y)
4949
y-=2
5050
end
5151

0 commit comments

Comments
 (0)