-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add newer Elixir versions on CI #83
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mopp
commented
Aug 15, 2023
@@ -42,7 +42,7 @@ defmodule TelemetryMetricsStatsd.MixProject do | |||
{:telemetry_metrics, "~> 0.6"}, | |||
{:nimble_options, "~> 0.4 or ~> 1.0"}, | |||
{:stream_data, "~> 0.4", only: :test}, | |||
{:dialyxir, "~> 0.5", only: :test, runtime: false}, | |||
{:dialyxir, "~> 1.3", only: :test, runtime: false}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I faced the error below on Elixir 1.15.x
> mix dialyzer
Checking PLT...
[:compiler, :elixir, :kernel, :liveness, :logger, :meck, :mock, :nimble_options,
:stdlib, :stream_data, :telemetry, :telemetry_metrics, :tools]
Finding suitable PLTs
Looking up modules in dialyxir_erlang-26.0.1_elixir-1.15.0_deps-test.plt
Looking up modules in dialyxir_erlang-26.0.1_elixir-1.15.0.plt
Looking up modules in dialyxir_erlang-26.0.1.plt
Finding applications for dialyxir_erlang-26.0.1.plt
Finding modules for dialyxir_erlang-26.0.1.plt
Creating dialyxir_erlang-26.0.1.plt
:dialyzer.run error: Analysis failed with error:
{undef,[{prettypr,text,["'true'"],[]},
{cerl_prettypr,lay_ann,2,[{file,"cerl_prettypr.erl"},{line,401}]},
{cerl_prettypr,format,2,[{file,"cerl_prettypr.erl"},{line,261}]},
{dialyzer_dataflow,signal_guard_failure,5,
[{file,"dialyzer_dataflow.erl"},{line,2477}]},
{dialyzer_dataflow,bind_guard,3,
[{file,"dialyzer_dataflow.erl"},{line,1710}]},
{dialyzer_dataflow,do_clause,7,
[{file,"dialyzer_dataflow.erl"},{line,1268}]},
{dialyzer_dataflow,handle_clauses,9,
[{file,"dialyzer_dataflow.erl"},{line,1199}]},
{dialyzer_dataflow,handle_case,3,
[{file,"dialyzer_dataflow.erl"},{line,932}]}]}
Last messages in the log cache:
Reading files and computing callgraph... done in 0.16 secs
Removing edges... done in 0.01 secs
Looking up modules in dialyxir_erlang-26.0.1.plt
** (Mix) Could not open /home/mopp/.mix/dialyxir_erlang-26.0.1.plt: no such file or directory
02:03:04.618 [error] Process #PID<0.1714.0> raised an exception
** (UndefinedFunctionError) function :prettypr.text/1 is undefined (module :prettypr is not available)
:prettypr.text(~c"'true'")
(dialyzer 5.1) cerl_prettypr.erl:401: :cerl_prettypr.lay_ann/2
(dialyzer 5.1) cerl_prettypr.erl:261: :cerl_prettypr.format/2
(dialyzer 5.1) dialyzer_dataflow.erl:2477: :dialyzer_dataflow.signal_guard_failure/5
(dialyzer 5.1) dialyzer_dataflow.erl:1710: :dialyzer_dataflow.bind_guard/3
(dialyzer 5.1) dialyzer_dataflow.erl:1268: :dialyzer_dataflow.do_clause/7
(dialyzer 5.1) dialyzer_dataflow.erl:1199: :dialyzer_dataflow.handle_clauses/9
(dialyzer 5.1) dialyzer_dataflow.erl:932: :dialyzer_dataflow.handle_case/3
jeremyjh/dialyxir#478 might fix the error.
I just upgraded the dialyxir version.
Merged
mopp
force-pushed
the
run_on_newer_elixir
branch
from
August 24, 2023 03:19
10dd4f5
to
329ba90
Compare
``` warning: use Mix.Config is deprecated. Use the Config module instead Warning: config/config.exs:1 ```
mopp
force-pushed
the
run_on_newer_elixir
branch
from
August 24, 2023 10:56
329ba90
to
e54e43f
Compare
@arkgil Please review and merge this PR also 🙏 |
arkgil
reviewed
Aug 24, 2023
Co-authored-by: Arek Gil <arkadiusz@arkgil.net>
mopp
force-pushed
the
run_on_newer_elixir
branch
from
August 25, 2023 02:38
844d1b2
to
3756b85
Compare
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Please merge and review #82 in advance.
I will rebase this PR after merging it.
I added newer Elixir versions on CI and fixed the warnings and errors.
How to test
I confirmed that the CI was passed at the forked repository.
See mopp#3