Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newer Elixir versions on CI #83

Merged
merged 7 commits into from
Aug 25, 2023

Conversation

mopp
Copy link
Contributor

@mopp mopp commented Aug 15, 2023

Overview

Please merge and review #82 in advance.
I will rebase this PR after merging it.

I added newer Elixir versions on CI and fixed the warnings and errors.

How to test

I confirmed that the CI was passed at the forked repository.
See mopp#3

@@ -42,7 +42,7 @@ defmodule TelemetryMetricsStatsd.MixProject do
{:telemetry_metrics, "~> 0.6"},
{:nimble_options, "~> 0.4 or ~> 1.0"},
{:stream_data, "~> 0.4", only: :test},
{:dialyxir, "~> 0.5", only: :test, runtime: false},
{:dialyxir, "~> 1.3", only: :test, runtime: false},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I faced the error below on Elixir 1.15.x

> mix dialyzer
Checking PLT...
[:compiler, :elixir, :kernel, :liveness, :logger, :meck, :mock, :nimble_options,
 :stdlib, :stream_data, :telemetry, :telemetry_metrics, :tools]
Finding suitable PLTs
Looking up modules in dialyxir_erlang-26.0.1_elixir-1.15.0_deps-test.plt
Looking up modules in dialyxir_erlang-26.0.1_elixir-1.15.0.plt
Looking up modules in dialyxir_erlang-26.0.1.plt
Finding applications for dialyxir_erlang-26.0.1.plt
Finding modules for dialyxir_erlang-26.0.1.plt
Creating dialyxir_erlang-26.0.1.plt
:dialyzer.run error: Analysis failed with error:
{undef,[{prettypr,text,["'true'"],[]},
        {cerl_prettypr,lay_ann,2,[{file,"cerl_prettypr.erl"},{line,401}]},
        {cerl_prettypr,format,2,[{file,"cerl_prettypr.erl"},{line,261}]},
        {dialyzer_dataflow,signal_guard_failure,5,
                           [{file,"dialyzer_dataflow.erl"},{line,2477}]},
        {dialyzer_dataflow,bind_guard,3,
                           [{file,"dialyzer_dataflow.erl"},{line,1710}]},
        {dialyzer_dataflow,do_clause,7,
                           [{file,"dialyzer_dataflow.erl"},{line,1268}]},
        {dialyzer_dataflow,handle_clauses,9,
                           [{file,"dialyzer_dataflow.erl"},{line,1199}]},
        {dialyzer_dataflow,handle_case,3,
                           [{file,"dialyzer_dataflow.erl"},{line,932}]}]}
Last messages in the log cache:
  Reading files and computing callgraph... done in 0.16 secs
  Removing edges... done in 0.01 secs
Looking up modules in dialyxir_erlang-26.0.1.plt
** (Mix) Could not open /home/mopp/.mix/dialyxir_erlang-26.0.1.plt: no such file or directory

02:03:04.618 [error] Process #PID<0.1714.0> raised an exception
** (UndefinedFunctionError) function :prettypr.text/1 is undefined (module :prettypr is not available)
    :prettypr.text(~c"'true'")
    (dialyzer 5.1) cerl_prettypr.erl:401: :cerl_prettypr.lay_ann/2
    (dialyzer 5.1) cerl_prettypr.erl:261: :cerl_prettypr.format/2
    (dialyzer 5.1) dialyzer_dataflow.erl:2477: :dialyzer_dataflow.signal_guard_failure/5
    (dialyzer 5.1) dialyzer_dataflow.erl:1710: :dialyzer_dataflow.bind_guard/3
    (dialyzer 5.1) dialyzer_dataflow.erl:1268: :dialyzer_dataflow.do_clause/7
    (dialyzer 5.1) dialyzer_dataflow.erl:1199: :dialyzer_dataflow.handle_clauses/9
    (dialyzer 5.1) dialyzer_dataflow.erl:932: :dialyzer_dataflow.handle_case/3

jeremyjh/dialyxir#478 might fix the error.
I just upgraded the dialyxir version.

@mopp mopp marked this pull request as ready for review August 24, 2023 10:57
@mopp
Copy link
Contributor Author

mopp commented Aug 24, 2023

@arkgil Please review and merge this PR also 🙏

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
mopp and others added 2 commits August 25, 2023 11:35
Co-authored-by: Arek Gil <arkadiusz@arkgil.net>
@ludwikbukowski
Copy link

nice!

@arkgil arkgil merged commit 7af8103 into beam-telemetry:main Aug 25, 2023
9 checks passed
@mopp mopp deleted the run_on_newer_elixir branch August 28, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants