Skip to content

Comments

[git] modules: use https instead of git#149

Merged
StykMartin merged 1 commit intobeaker-project:release-28from
adiosnb:hotfix/git-submodules-protocol
May 16, 2022
Merged

[git] modules: use https instead of git#149
StykMartin merged 1 commit intobeaker-project:release-28from
adiosnb:hotfix/git-submodules-protocol

Conversation

@adiosnb
Copy link
Contributor

@adiosnb adiosnb commented Mar 17, 2022

Unencrypted git protocol become obsolete and prohibited by some systems [0]. Some of our projects are dependent on beaker-client and beaker-common. However, pipenv locking fails due to old git protocol. This pull request contains fixed protocol in submodules.

I am opening PR into master to include the fix ASAP. If you have a different development workflow and it violates your plans, feel free to move it into develop branch.

[0] https://github.blog/2021-09-01-improving-git-protocol-security-github/

@StykMartin StykMartin changed the base branch from master to release-28 May 16, 2022 06:57
@StykMartin
Copy link
Contributor

HI @adiosnb,

I changed the target brach for the change. Changes will propagate to all branches within a few days.

@StykMartin StykMartin merged commit 0e33d50 into beaker-project:release-28 May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants