Add generic deduplication fix

Author: bcssov

src/IronyModManager.Services/ModService.cs

@@ -747,6 +747,11 @@ protected virtual ParsedSearchResult CleanSearchResult(ISearchParserResult parse
         /// <returns>IEnumerable&lt;IModInstallationResult&gt;.</returns>
         protected virtual IEnumerable<IModInstallationResult> GetAllModDescriptors(string path, ModSource modSource, ModDescriptorType modDescriptorType)
         {
+            bool IsSubPath(string path, string potentialParent)
+            {
+                return path.StartsWith(potentialParent.TrimEnd('\\') + "\\", StringComparison.OrdinalIgnoreCase);
+            }
+
             // Json metadata doesn't support zips to ignore them
             var files = Directory.Exists(path) && modDescriptorType == ModDescriptorType.DescriptorMod
                 ? Directory.EnumerateFiles(path, $"*{Shared.Constants.ZipExtension}").Union(Directory.EnumerateFiles(path, $"*{Shared.Constants.BinExtension}"))
@@ -756,21 +761,14 @@ protected virtual IEnumerable<IModInstallationResult> GetAllModDescriptors(strin
 
             static void setDescriptorPath(IMod mod, string desiredPath, string localPath)
             {
-                if (desiredPath.Equals(localPath, StringComparison.OrdinalIgnoreCase))
+                if (desiredPath.Equals(localPath, StringComparison.OrdinalIgnoreCase) || mod.RemoteId.GetValueOrDefault() > 0)
                 {
                     mod.DescriptorFile = desiredPath;
                 }
                 else
                 {
-                    if (mod.RemoteId.GetValueOrDefault() > 0)
-                    {
-                        mod.DescriptorFile = desiredPath;
-                    }
-                    else
-                    {
-                        mod.Source = ModSource.Local;
-                        mod.DescriptorFile = localPath;
-                    }
+                    mod.Source = ModSource.Local;
+                    mod.DescriptorFile = localPath;
                 }
             }
 
@@ -836,6 +834,7 @@ void parseModFiles(string path, ModSource source, bool isDirectory, string modNa
                         ? $"{Shared.Constants.ModDirectory}/{cleanedPath.Split(Path.DirectorySeparatorChar, StringSplitOptions.RemoveEmptyEntries).LastOrDefault()}{Shared.Constants.ModExtension}"
                         : $"{Shared.Constants.JsonModDirectory}/{cleanedPath.Split(Path.DirectorySeparatorChar, StringSplitOptions.RemoveEmptyEntries).LastOrDefault()}{Shared.Constants.JsonExtension}";
 
+                    // ReSharper disable once SwitchStatementHandlesSomeKnownEnumValuesWithDefault
                     switch (mod.Source)
                     {
                         case ModSource.Local:
@@ -924,7 +923,7 @@ void parseModFiles(string path, ModSource source, bool isDirectory, string modNa
                     }
 
                     var subdirectories = Directory.GetDirectories(directory);
-                    if (subdirectories.Length != 0 && modSourceOverride != ModSource.Steam)
+                    if (subdirectories.Length != 0)
                     {
                         foreach (var subdirectory in subdirectories)
                         {
@@ -938,7 +937,11 @@ void parseModFiles(string path, ModSource source, bool isDirectory, string modNa
                 });
             }
 
-            return [.. mods];
+            var filtered = mods
+                .Where(x => !mods.Any(y => x != y && IsSubPath(x.Path, y.Path)))
+                .ToList();
+
+            return [.. filtered];
         }
 
         /// <summary>