Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pkg-config support #925

Open
gdt opened this issue May 21, 2023 · 0 comments
Open

Add pkg-config support #925

gdt opened this issue May 21, 2023 · 0 comments
Labels
build issue in unison build system effort-low issue is likely resolvable with <= 5h of effort enhancement issue is a request for a feature, and not a defect impact-low low importance

Comments

@gdt
Copy link
Collaborator

gdt commented May 21, 2023

When looking for C libraries, unison's must determine CPPFLAGS and LDFLAGS. Lacking a system like autoconf, this is necessarily a bit ad hoc. Because for many libraries, pkg-config is the standard interface to obtain this information, it makes sense to rely on it, both to avoid encoding platform-specific information in our makefiles, and to enable building in a wide variety of environments.

It is important to keep the build system simple and for failures to be easy to understand. A possible path to this is to have a build target "check-pkg-config" which succeeds if pkg-config exists by something like pkg-config --version > /dev/null, and for rules using pkg-config to depend on that rule and simply assume pkg-config exists.

Note that this is an intentional choice to optimize for maintainability and minimizing time responding to misfiled bug reports, rather than a better experience for people that haven't read INSTALL.md.

The concept has been floated on unison-users@.

@gdt gdt added enhancement issue is a request for a feature, and not a defect effort-low issue is likely resolvable with <= 5h of effort impact-low low importance build issue in unison build system labels May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build issue in unison build system effort-low issue is likely resolvable with <= 5h of effort enhancement issue is a request for a feature, and not a defect impact-low low importance
Projects
None yet
Development

No branches or pull requests

1 participant