Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blockstore: tests failing on windows because of paths #809

Closed
tuxcanfly opened this issue Jul 1, 2019 · 2 comments · Fixed by #884
Closed

blockstore: tests failing on windows because of paths #809

tuxcanfly opened this issue Jul 1, 2019 · 2 comments · Fixed by #884
Labels
environment quick Can be fixed quickly, code change less than 10 lines tests Has tests for code change is just an addtional test

Comments

@tuxcanfly
Copy link
Member

Example::

AssertionError [ERR_ASSERTION]: "\\tmp\\.bcoin\\blocks\\blk00000.dat" strictEqual "/tmp/.bcoin/blocks/blk00000.dat"
@pinheadmz
Copy link
Member

I'm surprised this isn't causing more issues - is there something wrong with os.tmpdir() from certain node versions on windows?

@braydonf
Copy link
Contributor

@pinheadmz It's just the difference in behavior of join, nothing to do with that.

@tuxcanfly tuxcanfly added quick Can be fixed quickly, code change less than 10 lines tests Has tests for code change is just an addtional test labels Oct 17, 2019
@tuxcanfly tuxcanfly mentioned this issue Oct 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
environment quick Can be fixed quickly, code change less than 10 lines tests Has tests for code change is just an addtional test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix blockstore paths for windows tuxcanfly/bcoin
3 participants
@tuxcanfly @braydonf @pinheadmz