Memory exhaustion crash with full node sync (Node.js v9.9.0)

[braydonf]

Versions
bcoin v1.0.2 (f57bd51 latest master branch)
nodejs v9.9.0

Expected

A full node to completely sync and not over allocate memory.

Actual

A full node will over allocate memory during the initial sync:

[debug] (chain) Memory: rss=2504mb, js-heap=1368/1425mb native-heap=1079mb
[info] (chain) Block 00000000000008079751b074b5c8c5e36e40880fa8884e5ba791586d1f0ffc63 (136400) added to chain (size=2326 txs=5 time=1.93599).

Here the memory is getting dangerously close to the max.

Reproduce

Switch to use nodejs v9.9.0:

nvm install v9.9.0

Alternatively use n v9.9.0 or another preferred method.

Start a fresh sync for mainnet:

./bin/bcoin

Watch the logs and see the js-heap grow in size until... you know the rest.

Resolution

Switch to nodejs v10, and start the sync again and watch the logs and see the js-heap does not keep growing in size.

---

Thanks to @tuxcanfly for identifying the issue.

[braydonf]

Closed by #903 as Node.js v9.9.0 is less than v10.