Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing transactions for address index #734

Closed
jlopp opened this issue Mar 21, 2019 · 7 comments · Fixed by #758
Closed

missing transactions for address index #734

jlopp opened this issue Mar 21, 2019 · 7 comments · Fixed by #758

Comments

@jlopp
Copy link
Contributor

jlopp commented Mar 21, 2019

I've run into a number of addresses that don't seem to have their transactions indexed and was wondering if this is a known issue or if there might be an explanation. Examples (testnet):

curl http://127.0.0.1:18332/tx/address/tb1q7payj0epr8r98293s2hydrgs5045gh72gfnrn6
[]
curl http://127.0.0.1:18332/tx/address/2N846L41qya6WB2Mc5v2hALy2X2B87MFnGc
[]
curl http://127.0.0.1:18332/tx/address/2N9FY2fckLiZtdUEWSMYPe5Zrs1baHX7foG
[]
@pinheadmz
Copy link
Member

I think this is the same issue as #733, there is a known issue requesting history for addresses with too many transactions

@jlopp
Copy link
Contributor Author

jlopp commented Mar 21, 2019

Maybe, though I filed this one differently because bcoin doesn't seem to be running into a resources / exhaustion issue. Rather, the above queries return instantly.

@tynes tynes added the bug Unexpected or incorrect behavior label Mar 21, 2019
@braydonf
Copy link
Contributor

braydonf commented Mar 25, 2019

This result is possible if the sync has not completely finished. Those addresses also have many transactions, as similar to the other issue posted, so it could still be related to #733 and #589.

@braydonf
Copy link
Contributor

I'm getting the same result with a testnet node that is completely synced.

@braydonf
Copy link
Contributor

braydonf commented Apr 3, 2019

@jlopp Have you verified that indexTX and indexAddress are enabled for testnet? If the indexes are not enabled, these endpoints will return an empty result, instead of throwing an error.

In my case, I had thought that the base ~/.bcoin/bcoin.conf would be loaded in the case that ~/.bcoin/testnet/bcoin.conf was not available, that had the indexes enabled, however that is not the case. Having added a ~/.bcoin/testnet/bcoin.conf with the indexes enabled I'm receiving results for p2sh addresses, and have verified that such getHashes of TX will get the hash for the above addresses, so there shouldn't be an issue with indexing those.

@braydonf
Copy link
Contributor

braydonf commented Apr 3, 2019

Indeed, this triggers the issue in #733 and #589:

curl http://127.0.0.1:18332/tx/address/2N9FY2fckLiZtdUEWSMYPe5Zrs1baHX7foG
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory

@braydonf
Copy link
Contributor

braydonf commented Apr 3, 2019

The endpoints that require indexes should likely through an error if the option is not enabled, instead of returning empty results, or disable the endpoints if the config is not enabled.

@braydonf braydonf added config networks and removed bug Unexpected or incorrect behavior labels Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants