Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why delete the webpack.app.js #685

Closed
Rustin170506 opened this issue Feb 2, 2019 · 4 comments
Closed

Why delete the webpack.app.js #685

Rustin170506 opened this issue Feb 2, 2019 · 4 comments

Comments

@Rustin170506
Copy link

"webpack": "webpack --mode production --config webpack.browser.js",
"webpack-browser": "webpack --mode production --config webpack.browser.js",
"webpack-compat": "webpack --mode production --config webpack.compat.js",
"webpack-app": "webpack --mode production --config webpack.app.js"

why delete these files ?

@pinheadmz pinheadmz added the help wanted User has a question, not critical label Feb 2, 2019
@pinheadmz
Copy link
Member

I think it's likely because webpack isn't listed as a dependency in package.json, an there is an overall motivation to reduce dependencies in general. Also the bcoin developers have produced bpkg: https://github.com/chjj/bpkg which replaces webpack

@Rustin170506
Copy link
Author

I think it's likely because webpack isn't listed as a dependency in package.json, an there is an overall motivation to reduce dependencies in general. Also the bcoin developers have produced bpkg: https://github.com/chjj/bpkg which replaces webpack

But the docs not have any explanation about this, and such as run in browser must have these file. So I think this is weird.

@pinheadmz
Copy link
Member

Well, luckily GitHub will preserve those webpack configs for all eternity in this old commit: https://github.com/bcoin-org/bcoin/tree/6f1a561db5fdc3c19387f8bff9759e090d7911aa

I am currently writing a new guide for bcoin.io that explains how to use bpkg instead of webpack, you might be interested in checking that out.

If you want to play with bcoin-in-a-browser, we maintain a webhost and proxy server here: http://bcoin.io/browser/

And then again, as for the motivation for clearing out the webpack config files, we'll have to ask @chjj

@nodech
Copy link
Member

nodech commented Feb 5, 2019

I commented this on #310 PR.

If you are using bcoin as a library, bcoin webpack configurations wont be respected.
If you want to deploy bcoin as a standalone app then you can use bpkg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants