Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API endpoint to set fee rate on a node #512

Open
bucko13 opened this issue Jul 2, 2018 · 3 comments
Open

API endpoint to set fee rate on a node #512

bucko13 opened this issue Jul 2, 2018 · 3 comments
Labels
enhancement Improving a current feature has PR Issue is addressed with a pull request http

Comments

@bucko13
Copy link
Contributor

bucko13 commented Jul 2, 2018

Currently this can only be done with the rpc settxfee call. Would be nice to have this exposed in the HTTP API.
@bucko13 bucko13 added the enhancement Improving a current feature label Jul 2, 2018
@bucko13
Copy link
Contributor Author

bucko13 commented Jul 2, 2018

Request from @BluSyn

@tuxcanfly
Copy link
Member

Do we want to have a different rate for each wallet or set the same rate across all wallets. settxfee changes it across all the wallets, whereas the HTTP API is specific to the wallet whose id is passed down.

@bucko13
Copy link
Contributor Author

bucko13 commented Jul 4, 2018

I think the idea is to just expose the same settxfee behavior in the REST API, so it would be at the node level (all wallets) rather than by individual wallets. That's a good point about the id though. It does make sense that this should probably be an admin endpoint which wouldn't need an id.

@tuxcanfly tuxcanfly mentioned this issue Jul 5, 2018
Open
@braydonf braydonf changed the title [FEATURE] API endpoint to set fee rate on a node API endpoint to set fee rate on a node Jun 5, 2019
@braydonf braydonf added the has PR Issue is addressed with a pull request label Jun 5, 2019
@braydonf braydonf added http rpc and removed rpc labels Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving a current feature has PR Issue is addressed with a pull request http
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tuxcanfly @braydonf @bucko13