Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet endpoints validating tx buffers should expect hex #463

Open
bucko13 opened this issue May 15, 2018 · 0 comments
Open

wallet endpoints validating tx buffers should expect hex #463

bucko13 opened this issue May 15, 2018 · 0 comments
Labels
enhancement Improving a current feature wallet Wallet related

Comments

@bucko13
Copy link
Contributor

bucko13 commented May 15, 2018

Sending raw tx's, for example when hitting the sign endpoint, give an error that they expect a buffer. Since JSON doesn't really recognize Buffers and just stringifies the object, what is actually expected is the hex version of the transaction. We should either update bval.buf to check for stringified version of a Buffer or add support for bval.hex and/or improve error messaging to be more clear about the expectation.

See here: https://github.com/bcoin-org/bcoin/blob/master/lib/wallet/http.js#L508

@pinheadmz pinheadmz added the enhancement Improving a current feature label Jan 22, 2019
@braydonf braydonf added the wallet Wallet related label Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving a current feature wallet Wallet related
Projects
None yet
Development

No branches or pull requests

3 participants