Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the compatibility of XML-RPC library with PHP 8 #6264

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

gxgpet
Copy link
Contributor

@gxgpet gxgpet commented Feb 10, 2024

After long thoughts and checks on this, I came up with this fix for the XML-RPC library for the new PHP 8 versions.

While I pushed a unit test and made manual tests by myself, anyone who actively uses this library and can test it with a real-world scenario would be much appreciated.

I don't see the need for the xh property to be a multi-dimensional array. If a new request gets fired, then the previous values won't be used at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant