Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3: Deprecation Warning for Dynamic Property Creation in Class #6298

Open
Richin opened this issue Sep 14, 2024 · 3 comments
Open

PHP 8.3: Deprecation Warning for Dynamic Property Creation in Class #6298

Richin opened this issue Sep 14, 2024 · 3 comments

Comments

@Richin
Copy link

Richin commented Sep 14, 2024

I encountered a deprecation warning in my PHP application. The warning message is as follows:

Severity: 8192

Message: Creation of dynamic property CI_Loader::$input is deprecated

Filename: core/Loader.php

Line Number: 1011
@Richin Richin changed the title PHP 8.3: Deprecation Warning for Dynamic Property Creation in MyClass PHP 8.3: Deprecation Warning for Dynamic Property Creation in Class Sep 14, 2024
@Richin Richin changed the title PHP 8.3: Deprecation Warning for Dynamic Property Creation in Class PHP 8.3: Deprecation Warning for Dynamic Property Creation in Class fix #6298 Sep 17, 2024
@Richin Richin changed the title PHP 8.3: Deprecation Warning for Dynamic Property Creation in Class fix #6298 PHP 8.3: Deprecation Warning for Dynamic Property Creation in Class Sep 17, 2024
@Richin
Copy link
Author

Richin commented Sep 17, 2024

This PR is linked with the issue #6299

@pocketarc
Copy link

@Richin Just letting you know that this is also addressed in #6173.

I quite like this PR because it explicitly marks CI properties, but unless I'm missing something, by not using #[\AllowDynamicProperties], this will still trigger deprecation warnings as soon as you try to load your own custom models (which are all dynamic properties).

@Richin
Copy link
Author

Richin commented Sep 17, 2024

@pocketarc
Thank you for the heads-up on #6173. I appreciate your feedback on this PR, and I agree that explicitly marking CI properties is a good approach.

However, you make an important point about deprecation warnings for custom models with dynamic properties. You are correct that without using #[\AllowDynamicProperties], we may still encounter issues when loading custom models that use dynamic properties.

Do you have any suggestions for balancing explicit property marking with support for custom dynamic models? I am interested in discussing solutions that could work for core CI properties and user-defined custom models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants