Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): handle no bitnami pvc in cleanup #1936

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix(ci): handle no bitnami pvc in cleanup #1936

merged 1 commit into from
Apr 22, 2024

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Apr 22, 2024 •
edited by github-actions bot
Loading

For Helm cleanup there have been unimportant, but ugly errors when there are no bitnami PVCs to clean up. This PR adds || true for that case.

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@DerekRoberts DerekRoberts self-assigned this Apr 22, 2024
@DerekRoberts DerekRoberts added bug Something isn't working github_actions Pull requests that update GitHub Actions code labels Apr 22, 2024
@DerekRoberts DerekRoberts marked this pull request as ready for review April 22, 2024 13:08
@DerekRoberts DerekRoberts enabled auto-merge (squash) April 22, 2024 13:08
@DerekRoberts DerekRoberts merged commit 6919dc6 into main Apr 22, 2024
22 checks passed
@DerekRoberts DerekRoberts deleted the fix/ci/cleanupError branch April 22, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishraomp mishraomp Awaiting requested review from mishraomp

Assignees

@DerekRoberts DerekRoberts

Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code
Projects
DevOps (NR)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DerekRoberts