Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): false pass #1890

Merged
merged 3 commits into from
Mar 22, 2024
Merged

fix(ci): false pass #1890

merged 3 commits into from
Mar 22, 2024

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Mar 21, 2024 •
edited by github-actions bot
Loading

Failing PR passed anyway and was merged. Prevent this from happening again.

#1887

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@DerekRoberts DerekRoberts marked this pull request as ready for review March 22, 2024 00:09
@DerekRoberts DerekRoberts self-assigned this Mar 22, 2024
@DerekRoberts DerekRoberts added bug Something isn't working github_actions Pull requests that update GitHub Actions code labels Mar 22, 2024
@DerekRoberts DerekRoberts merged commit 794ebcf into main Mar 22, 2024
20 checks passed
@DerekRoberts DerekRoberts deleted the fix/ci/mergedBroken branch March 22, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishraomp mishraomp Awaiting requested review from mishraomp

Assignees

@DerekRoberts DerekRoberts

Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code
Projects
DevOps (NR)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DerekRoberts