Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PIN screen lockout #2073

Closed
knguyenBC opened this issue Jul 16, 2024 · 5 comments
Closed

Update PIN screen lockout #2073

knguyenBC opened this issue Jul 16, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request spike

Comments

@knguyenBC
Copy link

knguyenBC commented Jul 16, 2024

Background
The current PIN screen features a modal that appears when the person is locked out of their app after 5 minutes of inactivity.
This modal interferes with the biometrics login, making the UI clunky and if errors messages appear, it will freeze the app.

Updated design
https://www.figma.com/design/mfUqAvZIeOsgxPqWTTp0SU/BC-Wallet-app?node-id=1531-5772&t=sMqtlLkRYUUmveAW-1

Given an existing BC Wallet user that has previously setup a PIN
And has let their app idle for more than 5 minutes
When they return to the BC Wallet app
Then they are informed they have been locked out of the app because of inactivity
And they can give their PIN again to regain access to the app

Note: If dev mode is enabled, add a dev mode setting to change the inactivity to Never, 1, 3, 5

Spike Goals:

  • How can we check for "app inactivity" (no touch/inputs)
@knguyenBC knguyenBC added the enhancement New feature or request label Jul 16, 2024
@nodlesh
Copy link
Contributor

nodlesh commented Jul 16, 2024

May I suggest removing the references to screens and such and just reference behaviour. Your designs will give the screen details. So with that said, it might look something like this,

Given an existing BC Wallet user that has previously setup a PIN
And has let their app idle for more than 5 minutes
When they return to the BC Wallet app
Then they are informed they have been locked out of the app because of inactivity
And they can give their PIN again to regain access to the app

The Acceptance Criteria above is still true and can be verified, but it doesn't have to change for minor design, messaging, or even minor flow changes.

@cvarjao cvarjao added the spike label Aug 1, 2024
@bryce-mcmath bryce-mcmath self-assigned this Aug 7, 2024
@bryce-mcmath
Copy link
Contributor

Here's a potential solution:
https://dev.to/gie3d/detect-user-idle-in-react-native-5fci

But it will need to be used in combination with our existing logic that checks for background time, as timeouts don't work properly when the app is backgrounded

@knguyenBC
Copy link
Author

@bryce-mcmath Is this in testflight yet? I don't see the settings in dev mode and I tried testing and it didn't lock.

@bryce-mcmath
Copy link
Contributor

@knguyenBC I understood this ticket to just be the spike

@knguyenBC
Copy link
Author

Is the spike complete? Was it discussed with the team with next steps/new ticket(s) created?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request spike
Projects
None yet
Development

No branches or pull requests

4 participants