Safe JCE Cipher input/output streams and AEAD support for LW Cipher input/output streams #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Rewrites of JCE javax.crypto.CipherInputStream and CipherOutputStream that don't silently eat invalid ciphertext exceptions and don't call doFinal() twice (i.e. can be used and used safely with AEAD ciphers). Improvement to LW API CipherInputStream and CipherOutputStream to support AEADBlockCiphers and simplify internal logic. Full testing of JCE and LW Cipher streams with common ciphers, including tampering of AEAD ciphertexts. Oracle bug refs for broken Cipher stream behaviour: - http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016171 (CipherInputStream masks ciphertext tampering with AEAD ciphers in decrypt mode) - http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016249 (CipherInputStream in decrypt mode fails on close with AEAD ciphers) - http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8012900 (CICO ignores AAD in GCM mode)
|
Merged with minor mods - jce.io became jcajce.io. |
franziskuskiefer
pushed a commit
to franziskuskiefer/bc-java
that referenced
this pull request
Feb 2, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the new tests here will fail on issues fixed by #31
Two parts to this:
Full testing of JCE and LW Cipher streams with common ciphers is included, including tampering of AEAD ciphertexts.
Oracle bug refs for broken Cipher stream behaviour: