-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
discuss new defaults #7
Comments
I would probably prefer Regarding random effects, I don't like the term Not sure what the best naming convention is here. Using |
the current You might want to chime in on #6 as well (got a bit derailed into terminology/API questions toward the end) ... e.g. |
|
@paul-buerkner; @dgrtwo what do you think about There's also the question of what the resulting columns should be called. PS @paul-buerkner , how would you feel about modifying your
? |
Gelman/Hill have some arguments against this naming (page 245), but it is closer to the nlm(e,4) world. |
This has been implemented now, closing it. Decided not to change |
inst/NEWS.Rd
now contains the following description, which is my preference for the (default) behaviour of mixed model tidiers. I don't actually understand the use case for whicheffects="ran_coefs"
(the old behaviour) is the desired default. I could see an argument foreffects="fixed"
(only) rather thaneffects=c("fixed","ran_pars")
, but slightly prefer the latter.Discuss.
The default behaviour of most mixed-model tidiers has changed/will gradually be changed to the following (description modified from TJ Mahr at <URL: https://github.com/tidyverse/broom/issues/96>):
The text was updated successfully, but these errors were encountered: