Skip to content

Commit 3f7210e

Browse files
committed
Try to make 17result.php more robust
This is our most common intermittent failure. I don't understand why it happens and can't reproduce it, but defining an explicit sort order seems worth a shot...
1 parent 40f2cfe commit 3f7210e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

ext/pgsql/tests/08escape.phpt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,13 @@ $db = pg_connect($conn_str);
4343

4444
// Insert binary to DB
4545
$escaped_data = pg_escape_bytea($data);
46-
pg_query("DELETE FROM ".$table_name." WHERE num = -9999;");
47-
$sql = "INSERT INTO ".$table_name." (num, bin) VALUES (-9999, CAST ('".$escaped_data."' AS BYTEA));";
46+
pg_query("DELETE FROM ".$table_name." WHERE num = 10000;");
47+
$sql = "INSERT INTO ".$table_name." (num, bin) VALUES (10000, CAST ('".$escaped_data."' AS BYTEA));";
4848
pg_query($db, $sql);
4949

5050
// Retrieve binary from DB
5151
for ($i = 0; $i < 2; $i++) {
52-
$sql = "SELECT bin::bytea FROM ".$table_name." WHERE num = -9999";
52+
$sql = "SELECT bin::bytea FROM ".$table_name." WHERE num = 10000";
5353
$result = pg_query($db, $sql);
5454
$row = pg_fetch_array($result, 0, PGSQL_ASSOC);
5555

ext/pgsql/tests/17result.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ include 'config.inc';
1010

1111
$db = pg_connect($conn_str);
1212

13-
$sql = "SELECT * FROM $table_name";
13+
$sql = "SELECT * FROM $table_name ORDER BY num";
1414
$result = pg_query($db, $sql) or die('Cannot query db');
1515
$rows = pg_num_rows($result);
1616

0 commit comments

Comments
 (0)