Skip to content

Commit b0cbe58

Browse files
committed
a11y: fix duplicate: div IDs
1 parent 981d653 commit b0cbe58

File tree

2 files changed

+20
-10
lines changed

2 files changed

+20
-10
lines changed

editor.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -348,15 +348,15 @@ <h2><i class="fa fa-unlock-alt"></i> <strong>{{ title }}</strong></h2>
348348
<div class="buttons_menu_item"><span id="mp-ver">MicroPython Version:</span> <script>document.write(UPY_VERSION);</script></div>
349349
</div>
350350
</div>
351-
<div id="small-icons" class="vbox">
351+
<div id="small-icons-left" class="vbox small-icons">
352352
<a aria-label="Zoom in" class="roundbutton holder zoomer action" tabindex="90" id="command-zoom-in" href="#" title="Zoom in">
353353
<div class="status-icon"><i class="fa fa-search-plus"></i></div>
354354
</a>
355355
<a aria-label="Zoom out" class="roundbutton holder zoomer action" tabindex="100" id="command-zoom-out" href="#" title="Zoom out">
356356
<div class="status-icon"><i class="fa fa-search-minus"></i></div>
357357
</a>
358358
</div>
359-
<div id="small-icons" class="vbox">
359+
<div id="small-icons-right" class="vbox small-icons">
360360
<a aria-label="Show snippets (code shortcuts)" class="roundbutton holder zoomer action" tabindex="110" id="command-snippet" href="#" title="Show snippets (code shortcuts)">
361361
<div class="status-icon"><i class="fa fa-cogs"></i></div>
362362
</a>

static/css/style.css

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,8 @@ h2 {
121121
border-radius: 0.5rem;
122122
}
123123

124-
#small-icons > *:not(:first-child) {
124+
#small-icons-left > *:not(:first-child),
125+
#small-icons-right > *:not(:first-child) {
125126
display: inline-block;
126127
cursor: pointer;
127128
}
@@ -131,7 +132,8 @@ h2 {
131132
cursor: pointer !important;
132133
}
133134

134-
#small-icons {
135+
#small-icons-left,
136+
#small-icons-right {
135137
width: 54px;
136138
min-width: 54px;
137139
display: -webkit-flex;
@@ -142,7 +144,8 @@ h2 {
142144
flex-direction: column;
143145
}
144146

145-
#small-icons .status-icon {
147+
#small-icons-left .status-icon,
148+
#small-icons-right .status-icon{
146149
width: 37px;
147150
height: 37px;
148151
border: 6px solid #FFCC33;
@@ -157,15 +160,20 @@ h2 {
157160
background: #FFFFFF;
158161
}
159162

160-
html[data-useragent*='MSIE 10.0'] #small-icons .status-icon {
163+
html[data-useragent*='MSIE 10.0'] #small-icons-left .status-icon {
164+
line-height: 2.15rem;
165+
}
166+
html[data-useragent*='MSIE 10.0'] #small-icons-right .status-icon {
161167
line-height: 2.15rem;
162168
}
163169

164-
#small-icons .win-status-icon{
170+
#small-icons-left .win-status-icon,
171+
#small-icons-right .win-status-icon {
165172
line-height: 2.2rem;
166173
}
167174

168-
#small-icons .holder {
175+
#small-icons-left .holder,
176+
#small-icons-right .holder {
169177
width: 56px;
170178
min-width: 56px;
171179
color: #336699;
@@ -409,7 +417,8 @@ a.command:hover {
409417
padding: .4em;
410418
}
411419

412-
#small-icons {
420+
#small-icons-left,
421+
#small-icons-right {
413422
min-width: 120px;
414423
display: -ms-flexbox;
415424
display: flex;
@@ -418,7 +427,8 @@ a.command:hover {
418427
flex-direction: row;
419428
}
420429

421-
#small-icons .holder {
430+
#small-icons-left .holder,
431+
#small-icons-right .holder {
422432
padding: 0.2em;
423433
}
424434

0 commit comments

Comments
 (0)