Skip to content

Commit 765613a

Browse files
g-bauerprehner
authored andcommitted
Make constructors in Parameter trait fallible (feos-org#161)
* Make constructors in Parameter trait fallible * Update changelogs * Update CHANGELOG.md Co-authored-by: Philipp Rehner <69816385+prehner@users.noreply.github.com> --------- Co-authored-by: Philipp Rehner <69816385+prehner@users.noreply.github.com>
1 parent 49581f3 commit 765613a

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2323
### Packaging
2424
- Updated `num-dual` dependency to 0.7. [#137](https://github.com/feos-org/feos/pull/137)
2525

26+
### Changed
27+
- Adjusted all models' implementation of the `Parameter` trait which now requires `Result`s in some methods. [#161](https://github.com/feos-org/feos/pull/161)
28+
2629
## [0.4.3] - 2023-03-20
2730
- Python only: Release the changes introduced in `feos-core` 0.4.2.
2831

feos-core/CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
4848
### Packaging
4949
- Updated `num-dual` dependency to 0.7. [#137](https://github.com/feos-org/feos/pull/137)
5050

51+
### Changed
52+
- Changed constructors of `Parameter` trait to return `Result`s. [#161](https://github.com/feos-org/feos/pull/161)
53+
5154
## [0.4.2] - 2023-04-03
5255
### Fixed
5356
- Fixed a wrong reference state in the implementation of the Peng-Robinson equation of state. [#151](https://github.com/feos-org/feos/pull/151)

src/uvtheory/parameters.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use feos_core::parameter::{Identifier, ParameterError};
1+
use feos_core::parameter::{{Identifier, ParameterError}, ParameterError};
22
use feos_core::parameter::{Parameter, PureRecord};
33
use lazy_static::lazy_static;
44
use ndarray::concatenate;

0 commit comments

Comments
 (0)