Adds method to access openocd in Windows

Author: willtoth

tools/openocd/defs.bzl

@@ -82,6 +82,8 @@ Example:
 )
 
 def _openocd_debug_server_impl(ctx):
+    # is_windows = "windows" in ctx.var['TARGET_CPU']
+    is_windows = ctx.host_configuration.host_path_separator == ";"
     interface_config_string = ""
     for config in ctx.attr.interface_configs:
         interface_config_string = interface_config_string + " -f " + config
@@ -92,20 +94,66 @@ def _openocd_debug_server_impl(ctx):
     if ctx.attr.transport:
         transport_string = "-c \"transport select %s\"" % (ctx.attr.transport)
     script_template = """
-{openocd} {interface_config_string} {transport_string} -c "adapter_khz {programmer_frequency}" {chip_config_string}
+{openocd} {interface_config_string} {transport_string} -c "adapter speed {programmer_frequency}" {chip_config_string}
 
 """
 
-    script = ctx.actions.declare_file("%s.sh" % ctx.label.name)
-    script_content = script_template.format(
-        openocd = ctx.file._openocd.short_path,
-        interface_config_string = interface_config_string,
-        chip_config_string = chip_config_string,
-        programmer_frequency = ctx.attr.programmer_frequency,
-        transport_string = transport_string,
-    )
+    script_content = ""
+    if is_windows:
+        # A bit of a hacky way to do this... The issue is Windows does not support
+        # symlinks which does not work well for runfiles in particular. To enable them
+        # the user must use Developer Mode, also not ideal. Instead:
+        # 1) Use the 'symlink' as a generic path to the root of openocd
+        # 2) Open the MANIFEST file (non-standard format, beware for future versions)
+        # 3) Find com_openocd and use the full path to the symlink
+        # 4) In batch script, cd to base of tool and call bin/openocd.exe directly
+        windows_script_prepend = """
+@echo off
+for /f "tokens=*" %%a in (MANIFEST) do call :SEARCH %%a %%a
+
+:SEARCH
+set str1=%1
+if /i "%str1:~0,11%"=="com_openocd" goto FOUND
+
+goto FAIL
+
+:FOUND
+for %%i in (%2) do call :MAKEPATH %%~di%%~pi
+
+goto EOF
+
+:MAKEPATH
+cd %1
+
+
+"""
+        windows_script_append = """
+goto EOF
+
+:FAIL
+
+:EOF
+
+"""
+        script = ctx.actions.declare_file("%s.bat" % ctx.label.name)
+        script_content = windows_script_prepend + script_template.format(
+            openocd = "\"bin/openocd.exe\"",
+            interface_config_string = interface_config_string,
+            chip_config_string = chip_config_string,
+            programmer_frequency = ctx.attr.programmer_frequency,
+            transport_string = transport_string,
+        ) + windows_script_append
+    else:
+        script = ctx.actions.declare_file("%s.sh" % ctx.label.name)
+        script_content = script_template.format(
+            openocd = ctx.file._openocd.short_path,
+            interface_config_string = interface_config_string,
+            chip_config_string = chip_config_string,
+            programmer_frequency = ctx.attr.programmer_frequency,
+            transport_string = transport_string,
+        )
     ctx.actions.write(script, script_content, is_executable = True)
-    runfiles = ctx.runfiles(files = [ctx.file._openocd])
+    runfiles = ctx.runfiles(files = [ctx.file._openocd] )
     return [DefaultInfo(executable = script, runfiles = runfiles)]
 
 openocd_debug_server = rule(

tools/openocd/openocd_repository.bzl

@@ -1,8 +1,8 @@
 def _get_platform_specific_config(os_name):
     _WINDOWS = {
-        "sha256": "1fb26bbcfd65dbabe747ce3c8467a1f1cece7253bde4a95de13c2267d422ed8b",
-        "prefix": "xpack-openocd-0.10.0-14",
-        "url": "https://github.com/xpack-dev-tools/openocd-xpack/releases/download/v0.10.0-14/xpack-openocd-0.10.0-14-win32-x64.zip",
+        "sha256": "b195e3c3e9fe3f4fe9dfd9780ff08336ef8ed3015a76cc883d9e21e57c456f33",
+        "prefix": "",
+        "url": "https://github.com/ntfreak/openocd/releases/download/v0.11.0/openocd-v0.11.0-i686-w64-mingw32.tar.gz",
     }
     _PLATFORM_SPECIFIC_CONFIGS = {
         "mac os x": {
@@ -45,8 +45,8 @@ def _openocd_repository_impl(repository_ctx):
     executable_extension = ""
     if "windows" in repository_ctx.os.name:
         executable_extension = ".exe"
-    repository_ctx.symlink("bin/openocd"+ executable_extension, "openocd" )
 
+    repository_ctx.symlink("bin/openocd"+ executable_extension, "openocd" )
     repository_ctx.file(
         "BUILD",
         content = """