Export closure_proto_aspect and document closure_grpc_web_library #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposing the aspect is required for the implementation of closure_grpc_web_library in https://github.com/grpc/grpc-web/
Yannic
force-pushed
the
expose_closure_proto_aspect
branch
from
53f2cab
to
16e0cde
Compare
Yannic
changed the title
|
This sounds awesome! I would like to try |
|
@Yannic Would it be possible to get this change in soon? I would really like to try this bazel rule in my project. |
dslomov
approved these changes
Oct 15, 2018
|
@dslomov Thanks for rebasing and updating 🎉 , is there an eta on when this will be released? |
ptmphuong
pushed a commit
to ptmphuong/rules_closure
that referenced
this pull request
Dec 9, 2022
…zelbuild#278) Exposing the aspect is required for the implementation of closure_grpc_web_library in https://github.com/grpc/grpc-web/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing the aspect is required for the implementation of
closure_grpc_web_library in https://github.com/grpc/grpc-web/