Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is not possible to set Starlark defined command line flags that come from a different repository #9065

Closed
aiuto opened this issue Aug 2, 2019 · 4 comments
Assignees
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Configurability platforms, toolchains, cquery, select(), config transitions

Comments

@aiuto
Copy link
Contributor

aiuto commented Aug 2, 2019

This is best shown with a reproducible example.

From within the Bazel source code, this works.
build --//tools/build_defs/pkg:incompatible_no_build_defs_pkg

From a different repository (for example, one where we want to run CI with all incompatible flags set), //tools/build_defs does not exist, so we have to refer to it via the repository name bazel exports:
build --@bazel_tools//tools/build_defs/pkg:incompatible_no_build_defs_pkg

Alas, that does not parse, either in bazel sources or in other repositories.

The severity of the issue is that owners of rule sets are unable to make an incompatible flag change that their downstream users can test.

@aiuto aiuto added team-Configurability platforms, toolchains, cquery, select(), config transitions untriaged labels Aug 2, 2019
@aiuto aiuto changed the title Is is not possible to set Starlark defined command line flags that come from a different repository It is not possible to set Starlark defined command line flags that come from a different repository Aug 2, 2019
@katre katre removed the untriaged label Aug 5, 2019
@katre
Copy link
Member

katre commented Aug 5, 2019

I don't know what is intended here, so leaving this for @gregestren to set type and priority levels.

@gregestren gregestren added the P2 We'll consider working on this in future. (Assignee optional) label Aug 5, 2019
@gregestren
Copy link
Contributor

Is this solved by #10039?

@gregestren
Copy link
Contributor

Let's consolidate these bugs into #11128.

When that one is fixed, it if doesn't address this we can re-open this.

@juliexxia
Copy link
Contributor

I just confirmed that this seems to be fixed by #10039

Random repo I used was

$ git clone git clone https://github.com/bazelbuild/rules_go
$ bazel build :default_nogo --@io_bazel_rules_go//go/config:incompatible_package_conflict_is_error=True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Development

No branches or pull requests

4 participants