Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Starlark getters for cc_toolchain depsets #7427

Closed
hlopko opened this issue Feb 14, 2019 · 2 comments
Closed

Expose Starlark getters for cc_toolchain depsets #7427

hlopko opened this issue Feb 14, 2019 · 2 comments
Assignees
@hlopko
Labels
P1 I'll work on this now. (Assignee required) team-Rules-CPP Issues for C++ rules type: feature request

Comments

@hlopko
Copy link
Member

hlopko commented Feb 14, 2019

When using platforms, there is no way to access FilesToBuild provider from c++ toolchain. It seems the common way to solve this is to expose domain specific getters on ToolchainInfo. So let's do that.

Blocking #6516.
@hlopko hlopko added type: feature request P1 I'll work on this now. (Assignee required) team-Rules-CPP Issues for C++ rules bazel 1.0 labels Feb 14, 2019
@hlopko hlopko self-assigned this Feb 14, 2019
@hlopko
Copy link
Member Author

hlopko commented Feb 14, 2019

CC @katre, @sergiocampama

@hlopko
Copy link
Member Author

hlopko commented Aug 23, 2019

This is fixed! :) https://docs.bazel.build/versions/master/skylark/lib/CcToolchainInfo.html#all_files

@hlopko hlopko closed this as completed Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hlopko hlopko

Labels
P1 I'll work on this now. (Assignee required) team-Rules-CPP Issues for C++ rules type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hlopko