-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artifact debug repr should include the owner #6272
Labels
P3
We're not considering working on this, but happy to review a PR. (No assignee)
team-Rules-API
API for writing rules/aspects: providers, runfiles, actions, artifacts
type: feature request
Comments
aiuto
added
team-Execution
team-Configurability
platforms, toolchains, cquery, select(), config transitions
and removed
team-Bazel
General Bazel product/strategy issues
team-Execution
labels
Oct 2, 2018
Assigning to configurability for now, this might be Execution. |
Reassigning to Starlark, since this is about |
jin
added
team-Starlark
and removed
team-Configurability
platforms, toolchains, cquery, select(), config transitions
labels
Oct 3, 2018
laurentlb
added
type: feature request
P2
We'll consider working on this in future. (Assignee optional)
and removed
untriaged
labels
Oct 16, 2018
brandjon
added
P4
This is either out of scope or we don't have bandwidth to review a PR. (No assignee)
and removed
P2
We'll consider working on this in future. (Assignee optional)
labels
Feb 17, 2021
brandjon
added
untriaged
team-Rules-API
API for writing rules/aspects: providers, runfiles, actions, artifacts
and removed
team-Build-Language
labels
Nov 4, 2022
comius
added
P3
We're not considering working on this, but happy to review a PR. (No assignee)
and removed
P4
This is either out of scope or we don't have bandwidth to review a PR. (No assignee)
untriaged
labels
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
P3
We're not considering working on this, but happy to review a PR. (No assignee)
team-Rules-API
API for writing rules/aspects: providers, runfiles, actions, artifacts
type: feature request
As of bf4123d,
Artifact
equality takes the artifact owner into account. Since the Starlarkrepr
ofArtifact
only prints the execpath, it's possible to have two artifacts,a
andb
, that have the same execpath (and thus repr) but satisfya != b
. Unsurprisingly, this generates confusion–even for seasoned Blaze developers. Therefore, I propose including the owner in the output ofprint
ing an artifact.The text was updated successfully, but these errors were encountered: