Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java_stub_template.txt as used in kotlin_rules does not work on windows. #5523

Closed
hsyed opened this issue Jul 5, 2018 · 3 comments
Closed
Labels
area-Windows Windows-specific issues and feature requests P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website

Comments

@hsyed
Copy link

hsyed commented Jul 5, 2018

I shouldn't have tackled the windows issue at this point I thought it would a quick job. Anyhow the embedded classpath variable has not been resolved off the correct RUNPATH.

Here is how the rules expand the template

I copied and adapted the underlying code from the scala rules removing stuff that I didn't think was needed.

This might apply to the scala_rules as well although it wraps the script. I see the classpath variable is produced with a ":".join([...]) so its not windows compatible.

I updated the variables to include the following just in case.

...
            "%needs_runfiles%": "1",
            "%runfiles_manifest_only%": "",
...

On a side note is the stub template available from one of the tool workspaces ? The scala and kotlin rules are retrieving it via http_file.

@lfpino
Copy link
Contributor

lfpino commented Jul 6, 2018

Assigning to @iirina for triage.

@lberki lberki added area-Windows Windows-specific issues and feature requests team-Rules-Java Issues for Java rules P2 We'll consider working on this in future. (Assignee optional) and removed category: rules > java labels Dec 3, 2018
@dslomov dslomov removed the team-Rules-Java Issues for Java rules label Feb 15, 2019
@dslomov
Copy link
Contributor

dslomov commented Feb 15, 2019

Please do not assign issues to more than one team.

@laszlocsomor laszlocsomor added P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) and removed P2 We'll consider working on this in future. (Assignee optional) labels Feb 28, 2019
@laszlocsomor
Copy link
Contributor

rules_kotlin maintainers are planning to opensource Google's own Kotlin 1.3 rules.
I expect that if they find problems on Windows, they'll file bugs.
So I'll close this bug now -- please reopen if it makes sense to.

@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Windows Windows-specific issues and feature requests P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

No branches or pull requests

6 participants