Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel test --noenable_runfiles creates runfiles symlinks on linux #22856

Open
peakschris opened this issue Jun 22, 2024 · 3 comments
Open

bazel test --noenable_runfiles creates runfiles symlinks on linux #22856

peakschris opened this issue Jun 22, 2024 · 3 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Local-Exec Issues and PRs for the Execution (Local) team type: bug type: documentation (cleanup)

Comments

@peakschris
Copy link

Description of the bug:

I've noticed a difference in behaviour between windows and linux when the --noenable_runfiles flag is explicitly specified on both platforms.

Windows: bazel test <target> --noeenable_runfiles does not create runfiles symlinks
Linux: bazel test <target> --noenable_runfiles does create runfiles symlinks

The linux behaviour of bazel test is different to bazel run. bazel run <target> --noenable_runfiles behaves as I would expect and does not create symlinks.

Is this expected? If not, I can create a minimal reproducer.

Thanks!

Which category does this issue belong to?

Local Execution

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

TBD, will share if needed

Which operating system are you running Bazel on?

windows and linux

What is the output of bazel info release?

7.1.2 and 7.2.0, same behaviour

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

If this is a regression, please try to identify the Bazel commit where the bug was introduced with bazelisk --bisect.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@github-actions github-actions bot added the team-Local-Exec Issues and PRs for the Execution (Local) team label Jun 22, 2024
@fmeum
Copy link
Collaborator

fmeum commented Jun 22, 2024

My understanding is that this is expected but not desired: The Unix test runner simply needs directory-based runfiles to function.

@peakschris
Copy link
Author

@fmeum ok, that's understandable. Is this something that can be fixed? In the meantime, could a warning be emitted if trying to run tests on linux with --noenable_runfiles set?

@zhengwei143 zhengwei143 added type: documentation (cleanup) P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels Jul 2, 2024
@meisterT
Copy link
Member

meisterT commented Jul 2, 2024

cc @lberki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Local-Exec Issues and PRs for the Execution (Local) team type: bug type: documentation (cleanup)
Projects
None yet
Development

No branches or pull requests

7 participants