Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CcGenerateDwp should take into account that some dwo files are not referenced by the binary file #19148

Open
anhlinh123 opened this issue Aug 2, 2023 · 1 comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-CPP Issues for C++ rules type: feature request

Comments

@anhlinh123
Copy link

Description of the feature request:

CcGenerateDwp takes all .dwo files as inputs and executed the dwp tool to collect all of them into the final dwp file.
Meanwhile, not all of the .o files are linked in the final binary.
That means the dwp file contains a lot of unused information and becomes unnecessarily big.

CcGenerateDwp should take that into account and remove unneeded .dwo files in the output dwp file.

Which category does this issue belong to?

No response

What underlying problem are you trying to solve with this feature?

Dwp files are too big, and contain so much unneeded info.

Which operating system are you running Bazel on?

Ubuntu

What is the output of bazel info release?

release 6.1.1

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@Pavank1992 Pavank1992 added the team-Rules-CPP Issues for C++ rules label Aug 2, 2023
@buildbreaker2021 buildbreaker2021 added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels Aug 16, 2023
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-CPP Issues for C++ rules type: feature request
Projects
None yet
Development

No branches or pull requests

5 participants
@anhlinh123 @buildbreaker2021 @Pavank1992 @iancha1992 and others