Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the RBE Docker Sandbox on Windows #19101

Open
drfloob opened this issue Jul 27, 2023 · 1 comment
Open

Support the RBE Docker Sandbox on Windows #19101

drfloob opened this issue Jul 27, 2023 · 1 comment
Assignees
Labels
area-Windows Windows-specific issues and feature requests P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Local-Exec Issues and PRs for the Execution (Local) team type: feature request

Comments

@drfloob
Copy link

drfloob commented Jul 27, 2023

Description of the feature request:

The docker sandbox documentation does not mention that it's a posix-only feature, but it is.

if (OS.isPosixCompatible() && path != null && path.exists()) {
return new ProcessWrapper(path, killDelay, gracefulSigterm);
} else {
return null;
}

I would benefit from being able to run a clone of the RBE environment locally on Windows. I have been able to manually run our RBE docker image locally, but it's an onerous process for my project (gRPC), and it likely misses a lot of nuance that reproduces the RBE host and docker configurations.

Full context: yaqs/4469691788281511936

Attempting to run the docker sandbox configuration on Windows results in:

ERROR: Docker sandboxing is disabled because ProcessWrapper is not supported. This should never happen - is your Bazel binary corrupted?

What underlying problem are you trying to solve with this feature?

A rare gRPC flake that reproduces 5x per day in our CI with the rest of the test suite, but not in 100k one-off RBE runs of that individual test, and not in 100k runs locally on multiple machines.

Which operating system are you running Bazel on?

Windows 11 Pro 22H2 (among others)

What is the output of bazel info release?

Multiple

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

Confirmed broken on 5.4.1 and 6.3.0, using bazelisk and USE_BAZEL_VERSION="..."

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

If it would be helpful to you, I can provide links to complete bazel & RBE configurations, the code that I'm trying to test, build output, etc. But I imagine that's not useful here at the moment.

@iancha1992 iancha1992 added the area-Windows Windows-specific issues and feature requests label Jul 27, 2023
@iancha1992 iancha1992 added the team-Local-Exec Issues and PRs for the Execution (Local) team label Jul 27, 2023
@oquenchil oquenchil added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels Aug 1, 2023
@oquenchil oquenchil self-assigned this Aug 1, 2023
Copy link

github-actions bot commented Oct 5, 2024

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Windows Windows-specific issues and feature requests P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Local-Exec Issues and PRs for the Execution (Local) team type: feature request
Projects
None yet
Development

No branches or pull requests

5 participants