Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker_extra_flags not passed through to remote persistent workers #18138

Open
vaibhav-shah opened this issue Apr 18, 2023 · 5 comments
Open
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: bug

Comments

@vaibhav-shah
Copy link

Description of the bug:

worker_extra_flag works locally, but the supplied flags are not passed to the remote worker.

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@Pavank1992
Copy link
Contributor

Hi @vaibhav-shah, Could you please share minimal step to produce the issue with sample code?

@Pavank1992 Pavank1992 added team-Remote-Exec Issues and PRs for the Execution (Remote) team more data needed labels Apr 19, 2023
@coeuvre coeuvre added P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Apr 25, 2023
@larsrc-google
Copy link
Contributor

http://google3/third_party/bazel/src/main/java/com/google/devtools/build/lib/remote/RemoteExecutionService.java;l=524;rcl=526500829 handles the extra info the WorkerKey, but doesn't update the args AFAICT.

@larsrc-google
Copy link
Contributor

@benjaminp Any thoughts on whether this is feasible?

@benjaminp
Copy link
Collaborator

There would have to be a remote protocol change to allow the extra worker flags to be passed to the executor.

@larsrc-google larsrc-google assigned tjgq and unassigned larsrc-google Jul 4, 2023
@tjgq tjgq removed their assignment Oct 16, 2023
@tjgq tjgq added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed P2 We'll consider working on this in future. (Assignee optional) labels Oct 16, 2023
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: bug
Projects
None yet
Development

No branches or pull requests

8 participants