Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash completion fails if user has a "grep" alias that produces unexpected output formatting #1521

Closed
smu-ggl opened this issue Jul 14, 2016 · 1 comment
Labels
category: misc > misc P3 We're not considering working on this, but happy to review a PR. (No assignee) type: bug
Milestone

Comments

@smu-ggl
Copy link

smu-ggl commented Jul 14, 2016

Example:
alias grep="grep -P"

This could be avoided by using absolute paths for grep (and possibly other commands) or by protecting the relevant parts of the completion with "shopt -u expand_aliases" while executing the expansions.

I haven't done too much research yet, but this probably mostly affects
bazel-complete-template.bash lines 229 320 360 405 but probably not 190.

I'd suggest to just replace all occurrences of "grep" with /bin/grep (and probably do the same for sed)

@kchodorow kchodorow added type: bug P3 We're not considering working on this, but happy to review a PR. (No assignee) category: misc > misc labels Jul 14, 2016
@kchodorow kchodorow added this to the 0.5 milestone Jul 14, 2016
@damienmg
Copy link
Contributor

This was done 86a4047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: misc > misc P3 We're not considering working on this, but happy to review a PR. (No assignee) type: bug
Projects
None yet
Development

No branches or pull requests

3 participants