Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable spaces in exports_files #1441

Closed
abergmeier opened this issue Jun 23, 2016 · 3 comments
Closed

Enable spaces in exports_files #1441

abergmeier opened this issue Jun 23, 2016 · 3 comments
Labels
category: misc > misc P2 We'll consider working on this in future. (Assignee optional) type: bug

Comments

@abergmeier
Copy link
Contributor

abergmeier commented Jun 23, 2016

We put a binary Python archive in an external repo.

For that repository we had the BUILD file:

all_files = glob(["**"])

exports_files(srcs=all_files)

which is making Bazel complain about a target having a space (setuptools has a file with spaces in basename). Which I understand as a limitation for targets, but it is not always an option to remove paths with spaces from thirdparty libraries.

@philwo philwo added category: misc > misc type: bug P2 We'll consider working on this in future. (Assignee optional) labels Jun 24, 2016
@philwo
Copy link
Member

philwo commented Jun 24, 2016

The fact that not all filenames are valid label identifiers is unfortunately a long-standing issue with Bazel. I totally agree with you here, that this should just work. Unfortunately a lot of code currently relies on the fact that labels contain no special characters or whitespace - it will take a while to sort this all out. We hope to fix this soon, though!

@kchodorow
Copy link
Contributor

Possibly a dup of #167.

@damienmg
Copy link
Contributor

Definitely dup of #167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: misc > misc P2 We'll consider working on this in future. (Assignee optional) type: bug
Projects
None yet
Development

No branches or pull requests

4 participants