Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_file and http_archive can't make authenticated calls to Azure storage #14372

Closed
robin-wayve opened this issue Dec 3, 2021 · 6 comments
Closed
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request

Comments

@robin-wayve
Copy link
Contributor

robin-wayve commented Dec 3, 2021

Description of the problem / feature request:

Allow extra request headers to be passed to http_archive / http_file

Feature requests: what underlying problem are you trying to solve with this feature?

In order to download files from private Azure Storage, clients need to provide an OAuth2 token (which can be done via auth_patterns and a netrc file) and additionally set an x-ms-version header.

Docs: https://docs.microsoft.com/en-us/rest/api/storageservices/authorize-with-azure-active-directory

What operating system are you running Bazel on?

Ubuntu Linux 18.04

What's the output of bazel info release?

release 4.2.1

Have you found anything relevant by searching the web?

We checked if this might be possible through bazel-skylib or repository_ctx.download(_and_extract) but it does not seem so.

@thekyz
Copy link

thekyz commented Dec 3, 2021

This is a must have for companies relying on Azure for their cloud services (and can probably be used for other things as well).

@oquenchil oquenchil added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request untriaged labels Dec 7, 2021
@Wyverald Wyverald added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels Feb 7, 2022
@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Jun 13, 2023
@tjgq
Copy link
Contributor

tjgq commented Jun 13, 2023

You should be able to use a credential helper to do this.

@robin-wayve
Copy link
Contributor Author

So this closes with the 6.3.0 release?

@tjgq
Copy link
Contributor

tjgq commented Jun 13, 2023

Yes, 6.3.0 will be the first release to support this (it was cherry picked in #18429).

@github-actions github-actions bot removed the stale Issues or PRs that are stale (no activity for 30 days) label Jun 14, 2023
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request
Projects
None yet
Development

No branches or pull requests

5 participants