Skip to content

Commit 0323fc9

Browse files
committed
Remove FULLY_ASYNC mode from RemoteUploadMode enum
FULLY_ASYNC requires half-close support which is non-trivial to implement. Remove it for now since NOWAIT_FOR_UPLOAD_COMPLETE provides the main benefit.
1 parent 79abbd4 commit 0323fc9

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -133,11 +133,6 @@ public enum RemoteUploadMode {
133133
WAIT_FOR_UPLOAD_COMPLETE,
134134
/** Block at the beginning of the next build waiting for upload completion. */
135135
NOWAIT_FOR_UPLOAD_COMPLETE,
136-
/**
137-
* Block at the beginning of the next build waiting for client-side upload completion, but don't
138-
* wait for server acknowledgement. Data may be lost on transient failures.
139-
*/
140-
FULLY_ASYNC,
141136
}
142137

143138
/** Converter for {@link RemoteUploadMode}. */

0 commit comments

Comments
 (0)