Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazelbuild/bazel-skylib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.4.2
Choose a base ref
...
head repository: bazelbuild/bazel-skylib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.5.0
Choose a head ref
  • 9 commits
  • 31 files changed
  • 8 contributors

Commits on Aug 8, 2023

  1. Bump rules_pkg dep to 0.9.1 to fix build with --incompatible_config_s…

    …etting_private_default_visibility (#452)
    
    Required for Bazel 7 compatibility.
    
    Note that rules_pkg 0.9.1 requires Python 3.6 or newer as the system's Python 3; this means we cannot build //distribution on Ubuntu 16.04 any more (which is fine, since it only affects the skylib developer workflow; users of skylib on Ubuntu 16.04 are not affected). Update CI config accordingly.
    
    Fixes #414
    tetromino authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    6fcbad3 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Expose int- and string-valued build settings as Make variables (#440)

    While build settings allow for much cleaner flag and setting definitions
    than `--define`, they have the major drawback that rules need to provide
    dedicated support for them, which isn't the case for native and most
    community-maintained rules.
    
    This change attempts to bridge this gap by optionally exposing the value
    of the common build setting types as Make variables to rules that depend
    on them via the `toolchains` attribute: If the new `make_variable`
    attribute is set, the value of the flag or setting is available as a
    Make variable with that.
    
    Consistency with pre-defined Make variables is enforced by limiting the
    character set for `make_variable` values to `[A-Z0-9_]`. The new
    attribute is also only added to int- and string-valued build settings as
    the other types lack a canonical stringification.
    
    Co-authored-by: Xùdōng Yáng <wyverald@gmail.com>
    fmeum and Wyverald authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    8386b9d View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Modify actions in order not to need toolchain param (#455)

    All actions which use tool or executable for which is not clear if it comes from a toolchain, must set a `toolchain` parameter ( migration of Automatic Exec Groups). 
    
    As we discussed internally, I've modified actions so that it's recognised that tools are not from the toolchain. Hence, there will not be an error which states `Couldn't identify if tools are from implicit dependencies or a toolchain. Please set the toolchain parameter. If you're not using a toolchain, set it to 'None'.`. Hence, no need for the toolchain parameter.
    kotlaja authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    0171c69 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Configuration menu
    Copy the full SHA
    6bf7bae View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. versions: Don't fail on Bazel dev builds (#463)

    Dev builds of Bazel are assumed to be more recent than any released
    version.
    fmeum authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    652c8f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Add error for empty bzl_library (#457)

    This improves the error in the case your bzl_library does nothing.
    Otherwise you end up with something weirder later:
    
    ```
    BUILD:35:12: in deps attribute of bzl_library rule LABEL: 'DEP' does not produce any bzl_library deps files (expected .bzl)
    ```
    
    Ideally we could set `allow_empty = False` on `srcs` but currently it's
    valid to just have a bzl_library target that aggregates multiple other
    libraries in its deps.
    
    Co-authored-by: Ivo List <ilist@google.com>
    keith and comius authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    8da4759 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Configuration menu
    Copy the full SHA
    d77c6fb View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Upgrade rules_go (#460)

    comius authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    d17d369 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2023

  1. Configuration menu
    Copy the full SHA
    9c9beee View commit details
    Browse the repository at this point in the history
Loading