Add highs@1.12.0 #6652
Add highs@1.12.0 #6652
Conversation
|
Hello @galabovaa, modules you maintain (highs) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds version 1.12.0 of the highs module. The changes are generally well-structured, but there are a couple of critical issues in the MODULE.bazel file. Specifically, the rules_cuda dependency should be a development dependency, and there's an incorrect local CUDA toolchain configuration that will likely cause presubmit failures. I have provided suggestions to fix these issues.
Mizux
force-pushed
the
mizux/highs
branch
2 times, most recently
from
6df5e37 to
d19aca5
Compare
note: rules_cude seems not supported on macos x bazel6 trace: ``` (13:39:21) ERROR: /private/var/tmp/_bazel_buildkite/97e8b85d2d22add465857d2e1fde5a5a/external/highs~1.12.0/BUILD.bazel:34:13: While resolving toolchains for target @highs~1.12.0//:cupdlp: No matching toolchains found for types @rules_cuda~0.2.5//cuda:toolchain_type. To debug, rerun with --toolchain_resolution_debug='@rules_cuda~0.2.5//cuda:toolchain_type' If platforms or toolchains are a new concept for you, we'd encourage reading https://bazel.build/concepts/platforms-intro. (13:39:21) ERROR: Analysis of target '@highs~1.12.0//:cupdlp' failed; build aborted: ```
meteorcloudy
force-pushed
the
mizux/highs
branch
from
201db5b to
09652cf
Compare
|
Great, thank you @Mizux! I tried to do this but was not sure what to do about dev_dependency. LGTM! For the next release, should I update the HiGHS MODULE.bazel so this patch is not needed? Testing locally is fine, at least on Linux. |
3 participants
@galabovaa friendly ping ;)
note: I've disabled bazel 6.x presubmit since rules_cuda seems to not support macos x bazel 6.