Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: dismiss_approvals workflow dismisses approvals that occur after any changes that would dismiss the approval #2363

Open
jsharpe opened this issue Jul 4, 2024 · 1 comment
Open

[Bug]: dismiss_approvals workflow dismisses approvals that occur after any changes that would dismiss the approval #2363

jsharpe opened this issue Jul 4, 2024 · 1 comment
Assignees
@meteorcloudy
Labels
bug Something isn't working

Comments

@jsharpe
Copy link
Contributor

jsharpe commented Jul 4, 2024

What happened?

Made a change to a PR that would require re-approval by module owner.
Re-approved the PR before the github action to dimiss_approvals completed.
Approval got dismissed

Version

N/A - bug in github workflow

How to reproduce

No response

Any other information?

Can be seen in PR #2359
@jsharpe jsharpe added the bug Something isn't working label Jul 4, 2024
@jsharpe
Copy link
Contributor Author

jsharpe commented Jul 4, 2024

Also, its kind of annoying that it also dimisses changes by myself when I am the maintainer of the module. Maybe it should also check if the changes have been made by the maintainer not to dismiss any approvals?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meteorcloudy meteorcloudy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsharpe @meteorcloudy