[CI-shell-tests] Support granular test timeout #1125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
or-shachar
changed the title
liucijus
approved these changes
Oct 26, 2020
ittaiz
approved these changes
Oct 26, 2020
blorente
pushed a commit
to twitter-forks/rules_scala
that referenced
this pull request
Nov 26, 2020
* Testing short test timeout * Now using realistic timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I wanna add a way for specifying specific timeout per test. Currently there's a global timeout of 60 minutes per test while in travis the timeout it for each test suite is 50 minutes.
When travis terminates the run in the middle of test run, we can't even see the logs of the timing out test. Using this mechanism we can terminate the test ourselves and see the output.
Motivation
I looked at travis job from this PR
draft notice
I'm checking it now with super low timeout in purpose - I wanna see how it looks like.- see first commit travis to see example for failure on timeout..PR is ready to merge AFAIC.
FYI: @liucijus