Add neverlink support #1123
Merged
Add neverlink support #1123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisechengyi
approved these changes
Oct 20, 2020
Contributor
wisechengyi
left a comment
wisechengyi
left a comment
There was a problem hiding this comment.
Thank you, @liucijus !
ittaiz
approved these changes
Oct 21, 2020
blorente
pushed a commit
to twitter-forks/rules_scala
that referenced
this pull request
Nov 26, 2020
* Add neverlink support * Fix tests meaning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes neverlink attribute to JavaInfo via compile phase. Can be extracted into a separate phase after bazelbuild/bazel#11928 is fixed.
Solves #213