Skip to content

Conversation

@or-shachar
Copy link
Contributor

Description

Suggesting a very straightforward change.

  1. Making sure we are using the a release version of bazeltools so we can keep track of how far behind are we
  2. Updating to the latest release 3.3.0

Motivation

In general - we do want to make sure that our code is well linted.

I wanted to check out what we already have and I noticed that the current lint.sh only calls bazel run //tools:buildifier@fix which depends on the version of buildifier we bring from the WORKSPACE.

Without getting into the details I wanted to make sure we use the latest version and that it's easy to understand which version we depend on.

@or-shachar or-shachar requested a review from ittaiz as a code owner July 2, 2020 14:39
Copy link
Contributor

@ittaiz ittaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ittaiz ittaiz merged commit 1b9f63b into bazel-contrib:master Jul 4, 2020
@ittaiz ittaiz deleted the release-version-build-tools branch July 4, 2020 05:04
SocksDevil pushed a commit to SocksDevil/rules_scala that referenced this pull request Jul 6, 2020
SocksDevil pushed a commit to SocksDevil/rules_scala that referenced this pull request Jul 6, 2020
SocksDevil pushed a commit to SocksDevil/rules_scala that referenced this pull request Jul 6, 2020
SocksDevil pushed a commit to SocksDevil/rules_scala that referenced this pull request Jul 6, 2020
SocksDevil pushed a commit to SocksDevil/rules_scala that referenced this pull request Jul 6, 2020
SocksDevil pushed a commit to SocksDevil/rules_scala that referenced this pull request Jul 6, 2020
SocksDevil pushed a commit to SocksDevil/rules_scala that referenced this pull request Jul 7, 2020
SocksDevil pushed a commit to SocksDevil/rules_scala that referenced this pull request Jul 7, 2020
SocksDevil pushed a commit to SocksDevil/rules_scala that referenced this pull request Jul 7, 2020
SocksDevil pushed a commit to SocksDevil/rules_scala that referenced this pull request Jul 7, 2020
SocksDevil pushed a commit to SocksDevil/rules_scala that referenced this pull request Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants