-
-
Notifications
You must be signed in to change notification settings - Fork 639
chore: enable pipstar for experimental_index_url users #3428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: enable pipstar for experimental_index_url users #3428
Conversation
Summary of ChangesHello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a targeted adjustment to how Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly enables pipstar more selectively to avoid issues with bazel query on platform-specific dependencies. The change enables pipstar for wheels that are provided directly via a label or downloaded with the Bazel downloader, which aligns with the stated goal. The logic is sound, and the changelog is updated accordingly. I've added one suggestion to improve the clarity of the new logic in whl_library.bzl.
bazel querymay break if users right now rely on the behaviour of:When we enabled
pipstarby default, one of our user reported this breakagebecause:
tritondependency is only used onlinuxand it is in one of therequirementsfiles.whl_libraryrepository materializedand the bazel query failed because of this reason.
Hence we enable
pipstarin a different way - we only enable it when whl filesare downloaded via the bazel downloader and
bazel queryis less likely to failif you can use the bazel downloader for all of your deps.
Work towards #2949