Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazel-contrib/rules_python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.0.0-rc2
Choose a base ref
...
head repository: bazel-contrib/rules_python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.0.0-rc3
Choose a head ref
  • 3 commits
  • 6 files changed
  • 3 contributors

Commits on Apr 20, 2026

  1. fix(pypi): skip index lookups when all package overrides are specified ( 

    #3710)

When index_url_overrides is provided for all packages, we no longer need
to
call the index at all. This improves performance and aligns with the
expected
behavior where overrides should be sufficient.

Just to note, currently Pytorch, PyPI, Artifactory have the root index
pages, whilst GAR does not.

Fixes #3709

(cherry picked from commit 208ca88)
    @aignas @rickeylev
    aignas authored and rickeylev committed Apr 20, 2026
    Configuration menu
    Copy the full SHA
    8c726cb View commit details
    Browse the repository at this point in the history

  2. fix(pypi): correctly write the used facts back (#3719) 

    Summary:
1. Added 3 new tests to pypi_cache_tests.bzl
2. Fixed `_cache` helper to handle both struct and dict return values
3. Fixed `_filter_packages`: Returns None for empty dict results instead
   of empty dict
4. Fixed `_get_from_facts`: Now stores facts when reading index_urls
   from the dict case

Fixes #3711
Fixes #3707

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
(cherry picked from commit 6da1431)
    @aignas @gemini-code-assist @rickeylev
    2 people authored and rickeylev committed Apr 20, 2026
    Configuration menu
    Copy the full SHA
    577bb1f View commit details
    Browse the repository at this point in the history

  3. fix(pypi): build the environment on the fly (#3720) 

    At some point when we started using pipstar, we silently started
building the python environment with system python interpreter. This is
fine because the environment in those code paths would be unused, but
this would break if python was not present on the machine.

This PR fixes this by creating the environment on the fly with a little
bit of code duplication.

Fixes #3712

---------

Co-authored-by: Richard Levasseur <richardlev@gmail.com>
(cherry picked from commit 19a2c04)
    @aignas @rickeylev
    aignas and rickeylev committed Apr 20, 2026
    Configuration menu
    Copy the full SHA
    91b3224 View commit details
    Browse the repository at this point in the history
Loading